Put task_id in the meta information of a TaskException #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eehhh... Since the result is only keyed by the task ID already, this seems kind-of gross/unnecessary. Going to pass for now. |
|
Is there an option to fetch the task ID in a TaskException that I'm missing then? The result object does indeed have it but ideally I would be able to get the task ID wherever the exception is caught in the application. |
|
Fair enough, let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this we can catch the TaskException higher up and still have access to the task_id. Otherwise we need to catch the exception at every place where we try to fetch a result in order to be able to fetch the task_id from the result object.
I don't think adding this extra meta information has any downsides.