Added string utils and tests for the same #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM but could you change the file name of string.colgm, because there's already str.colgm in the std directory, or maybe you could merge this file into the std/str.colgm? Thanks. |
Contributor
Author
|
sure. I was thinking of putting this in str.colgm but it felt like str.colgm should be solely responsible for the str struct. I'll do the needful though, and move it to that file. or can we just make a new file called stringutils? |
Collaborator
|
i agree with this idea, rename it to string_utils.colgm.
…---Original---
From: ***@***.***>
Date: Sun, May 4, 2025 18:59 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [colgm/colgm] Added string utils and tests for the same (PR #12)
re-masashi left a comment (colgm/colgm#12)
sure. I was thinking of putting this in str.colgm but it felt like str.colgm should be solely responsible for the str struct. I'll do the needful though, and move it to that file. or can we just make a new file called stringutils?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Contributor
Author
|
thanks a ton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added string utils in src/std/string.colgm and also added some tests.