Fix classloading error on worker teardown after code change #5659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be caused by
MillBuildBootstrapclosing the classloader without closing the workers, resulting in some of the workers inworkerCachebeing loaded by an already-closed classloader, such that if they try to load a new class during teardown it fails with aNoClassDefFoundErrorThe solution is that in
MillBuildBootstrap, before we close each classloader, we need to first close all the workers for the next frame'sworkerCache, and set theworkerCachetoMap.emptywhen we later create the evaluator. This ensures that the workers get closed after the classloader that loaded them got closed, avoiding theNoClassDefFounderrors caused by the workerclose()code trying to load classes from a closed classloaderAdded an integration test to specifically exercise this case, that defines a worker with a class that is only used in
.close(). This fails onmain, and seems to pass on this PR