This repository was archived by the owner on May 16, 2024. It is now read-only.
Append IdentityGroupFilter to CF parameter list #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @keymon Can you please fix: I tried to add the error handling but did not have permission to update your branch |
chrnorm
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add the IdentityGroupFilter to CF parameter list, to
fix the issue #621
Why?
Otherwise the change is ignored
How did you test it?
Manually, using a manifest like below and running
gdeploy updateversion: 2 deployment: stackName: commonfate-non-prod account: "1234567890" region: us-west-2 release: v0.15.6 parameters: CognitoDomainPrefix: common-fate-non-prod-login-mycompany AdministratorGroupID: vhjdsfbkgbsakdng1 IdentityProviderType: okta SamlSSOMetadataURL: https://mycompany-test.oktapreview.com/app/exka4ccnoe1AZdYy91d7/sso/saml/metadata + IdentityGroupFilter: "Okta-App.*Commonfate|commonfate_example.*" ProviderConfiguration: okta: uses: commonfate/okta@v1 with: apiToken: awsssm:///granted/providers/okta/apiToken:1 orgUrl: https://mycompany-test.oktapreview.com IdentityConfiguration: okta: apiToken: awsssm:///granted/secrets/identity/okta/token:4 orgUrl: https://mycompany-test.oktapreview.com/Checking a unit test
Potential risks
none I can think about
Is patch release candidate?
dunno
Link to relevant docs PRs
#621
https://docs.commonfate.io/common-fate/sso/filtering-user-group-import