Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 16, 2024. It is now read-only.

Conversation

@stonest
Copy link
Contributor

@stonest stonest commented Oct 10, 2023

…list of groups

What changed?

  • Added a new 'groups' field to the GoogleSync struct so that groups can be provided to only sync users from those groups
  • Created a new function ListUsersBasedOnGroups to only get users from the provided groups in config
  • Modified the ListUsers function to either list users from groups, or list all users if the groups field is omitted
  • Created a new function ListAllUsers to be called from ListUsers if no groups field is present in config

Why?

Our Google Workspace has over 4000 users, and when trying to synchronise all of those the lambda times out, or we hit a rate limit on the Workspace side resulting in the sync never finishing. This functionality is similar to what was implemented in Okta here #625

How did you test it?

Deployed a dev stack on our AWS platform and tested the functionality against it, both with no usersFromGroups field and with.

Potential risks

This shouldn't affect existing configs as the groups field is optional

Is patch release candidate?

No

@shwethaumashanker shwethaumashanker changed the base branch from main to release/v0.15 October 10, 2023 21:34
@shwethaumashanker shwethaumashanker changed the base branch from release/v0.15 to main October 10, 2023 21:34
@shwethaumashanker shwethaumashanker self-requested a review October 16, 2023 20:34
@shwethaumashanker shwethaumashanker merged commit 4700a00 into common-fate:main Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants