[p2p] log actual error instead of ChannelClosed #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Jun 4, 2025
| #[error("invalid channel")] | ||
| InvalidChannel, | ||
| #[error("channel closed: {0}")] | ||
| ChannelClosed(u32), |
There was a problem hiding this comment.
This was unused, so I removed it. Alternatively, we could keep this error and add an error field.
There was a problem hiding this comment.
I think this change makes sense 👍
patrick-ogrady
approved these changes
Jun 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 91.10% 91.09% -0.01%
==========================================
Files 191 191
Lines 54854 54852 -2
==========================================
- Hits 49972 49970 -2
Misses 4882 4882
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs the actual error instead of just
ChannelClosed.