[cryptography/bls12381] Use Rayon for Concurrent Recovery #1265
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the threshold signature recovery by introducing a configurable concurrency parameter and using Rayon to parallelize the recovery process.
- Adds a
concurrencyargument tothreshold_signature_recover_multiple - Builds a Rayon thread pool with the specified thread count
- Parallelizes per-eval signature recovery and updates
threshold_signature_recover_pairto pass a fixed concurrency of 2
Comments suppressed due to low confidence (2)
cryptography/src/bls12381/primitives/ops.rs:471
- Adding a new required
concurrencyparameter is a breaking API change; consider providing a default overload or marking the change in the next major version to preserve backward compatibility.
concurrency: usize,
cryptography/src/bls12381/primitives/ops.rs:471
- [nitpick] Parallel recovery logic with custom
concurrencyvalues should be covered by unit or integration tests (e.g.,concurrency=1,concurrency>tasks) to ensure correctness and no regressions.
concurrency: usize,
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 91.02% 91.02% -0.01%
==========================================
Files 236 236
Lines 57667 57684 +17
==========================================
+ Hits 52494 52505 +11
- Misses 5173 5179 +6
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future Work: #903