[adb] [sync] Change sync lower bound to be inactivity floor, not pruning boundary #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing of incosistent pruning boundaries
…est_sync_subset_of_target_database
…ning boundary in Current::commit
danlaine
commented
Jul 15, 2025
examples/sync/src/lib.rs
Outdated
| translator: Translator::default(), | ||
| thread_pool: None, | ||
| buffer_pool: commonware_runtime::buffer::PoolRef::new(1024, 10), | ||
| pruning_gap: 10, |
There was a problem hiding this comment.
Seems like an OK value to use during tests? It's sufficiently small such that the "gap" will exist even if we only insert relatively few operations into the database.
patrick-ogrady
approved these changes
Jul 16, 2025
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1277 +/- ##
==========================================
+ Coverage 91.09% 91.13% +0.03%
==========================================
Files 246 246
Lines 60496 60744 +248
==========================================
+ Hits 55110 55358 +248
Misses 5386 5386
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the lower bound supplied to the sync client was the pruning boundary of the target database.
This change makes it so the client instead receives the inactivity floor to use as the lower sync boundary.
The motivation for this change is that, during state sync, the client will request the operations in the sync target range from the server(s). If the client's sync lower bound is the server's pruning boundary, and the server continues to add operations and prune old operations, then it's likely the server will prune operations that the sync client needs to complete. Using the inactivity floor adds a buffer, making this situation less likely.