Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danlaine
Copy link
Collaborator

@danlaine danlaine commented Jul 17, 2025

This PR will update the sync example so that:

  1. The server continuously adds new operations
  2. The client repeatedly updates its target to a newer target

This PR resolves #1254

@danlaine danlaine self-assigned this Jul 17, 2025
@danlaine danlaine changed the base branch from main to danlaine/sync-fix-persistence-bug July 22, 2025 15:11
Base automatically changed from danlaine/sync-fix-persistence-bug to main July 22, 2025 20:45
@danlaine danlaine requested a review from patrick-ogrady July 22, 2025 20:55
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close!

@danlaine danlaine requested a review from patrick-ogrady July 22, 2025 23:07
@patrick-ogrady patrick-ogrady merged commit 900ff50 into main Jul 22, 2025
33 checks passed
@patrick-ogrady patrick-ogrady deleted the danlaine/sync-example-dynamic branch July 22, 2025 23:14
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 83.83234% with 27 lines in your changes missing coverage. Please review.

Project coverage is 91.21%. Comparing base (078ed74) to head (61d844d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
storage/src/adb/any/sync/mod.rs 0.00% 20 Missing ⚠️
utils/src/time.rs 97.22% 4 Missing ⚠️
storage/src/adb/any/mod.rs 0.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   91.21%   91.21%   -0.01%     
==========================================
  Files         247      248       +1     
  Lines       61770    62097     +327     
==========================================
+ Hits        56342    56639     +297     
- Misses       5428     5458      +30     
Files with missing lines Coverage Δ
utils/src/lib.rs 100.00% <ø> (ø)
storage/src/adb/any/mod.rs 98.91% <0.00%> (-0.21%) ⬇️
utils/src/time.rs 97.91% <97.22%> (-2.09%) ⬇️
storage/src/adb/any/sync/mod.rs 44.44% <0.00%> (-55.56%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078ed74...61d844d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sync] Update example so server continuously adds new operations

3 participants