[storage/adb/any] remove double-hashing of elements #1308
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a double-hashing issue in the adb::Any storage implementation where operations were being hashed before being added to the MMR (Merkle Mountain Range), which performs its own hashing internally.
- Removes the intermediate
op_digestfunction that was pre-hashing operations - Updates all MMR operations to use encoded operations directly instead of digests
- Simplifies verification logic by passing encoded elements rather than pre-computed hashes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| storage/src/adb/current.rs | Updates verification methods to use encoded operations instead of digests, adds Encode trait import |
| storage/src/adb/any/mod.rs | Removes op_digest function, updates MMR operations to use encoded data directly, fixes documentation formatting |
0f77d75 to
1b70188
Compare
1b70188 to
0250a85
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
+ Coverage 91.21% 91.22% +0.01%
==========================================
Files 247 248 +1
Lines 61770 61917 +147
==========================================
+ Hits 56342 56483 +141
- Misses 5428 5434 +6
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fixes issue where adb::Any was unnecessarily hashing database operations before putting them in the MMR, which does its own hashing of provided elements.