[storage/index] Implement Send for Cursor + miri CI
#1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Aug 7, 2025
|
|
||
| // Add `next` to the tail of `past`. | ||
| if self.past_tail.is_none() { | ||
| self.past_tail = Some(&mut *next); |
There was a problem hiding this comment.
This violated rust's alias-ing rules
Send for CursorSend for Cursor + miri CI
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1369 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 265 265
Lines 66021 66034 +13
=======================================
+ Hits 60292 60304 +12
- Misses 5729 5730 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.