[storage/adb/current] add benchmark for adb::current startup #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d13cfb to
42ee883
Compare
roberto-bayardo
previously approved these changes
Aug 12, 2025
42ee883 to
65713f7
Compare
patrick-ogrady
previously approved these changes
Aug 12, 2025
| CARGO_TERM_COLOR: always | ||
| UDEPS_VERSION: 0.1.50 | ||
| UDEPS_VERSION: 0.1.57 | ||
| NIGHTLY_VERSION: nightly-2025-08-10 |
There was a problem hiding this comment.
Pinned nightly to fix the udeps issue
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 91.34% 91.52% +0.18%
==========================================
Files 265 265
Lines 66726 67194 +468
==========================================
+ Hits 60950 61502 +552
+ Misses 5776 5692 -84
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code closely follows the current implementation of the
any_initbenchmark, which was originally raised in #1121, but is modified to be foradb::current. Addresses one component of issue #1309.This benchmarks the setup for current adb in both singlethreaded and multithreaded scenarios, and currently does so with a bitmap chunk size of 32 bytes (a 1x multiple of the SHA256 digest size).
It also fixes a missing functionality of deleting the persistent bitmap partition when closing a
adb::currentdatabase, by adding adestroy()function tobitmap.rsand calling it inadb::current::destroy()The full thread for this PR can be found here: #1346