[consensus/{threshold_simplex, aggregation}] Replay Activity #1424
Conversation
consensus/src/aggregation/mod.rs
Outdated
| if tip_index >= target_index { | ||
| // Verify that validator has signed messages at all indices | ||
| for check_index in 0..=tip_index { | ||
| for check_index in 0..=target_index { |
There was a problem hiding this comment.
We just care about reaching tip_index...when restarts are fast enough, we only have everything signed up to tip_index by chance.
There was a problem hiding this comment.
TBH, I'm not sure how this test ever worked before because we destroy the reporter on each restart?
There was a problem hiding this comment.
Well, it didn't work because we just skipped missing signed messages 🙃 : #1425
There was a problem hiding this comment.
This more or less became a test of "can we iterate through tip_index values before timeout"
| == self.crypto.public_key(); | ||
| self.handle_finalize(finalize).await; | ||
| self.handle_finalize(finalize.clone()).await; | ||
| self.reporter.report(Activity::Finalize(finalize)).await; |
There was a problem hiding this comment.
Is it possibly better to just put report inside of the handle_X functions?
There was a problem hiding this comment.
I decoupled the two because the batch verifier sends the report operation during "steady state" ASAP (we only issue reports from the voter for recovered broadcast).
Admittedly this is all a bit confusing (and am not in love with any of this reporting architecture atm).
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 275 275
Lines 69392 69204 -188
==========================================
- Hits 63651 63477 -174
+ Misses 5741 5727 -14
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Related: #1417
Related: #573 (proper fix)
TODO