[storage/adb/keyless] fix authentication/proving in the keyless db #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes authentication and proving in the keyless database by changing how operations are stored. Previously, only offsets were stored in the authenticated portion, but now the actual values are included to enable proper proving functionality.
Key changes:
- Modified the
Keylessoperation enum to store values instead of offsets inAppendoperations - Moved operation types from the locations journal to the values journal
- Updated the storage structure to use values journal for operations and locations journal for offsets
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| storage/src/store/operation.rs | Updated Keyless enum to be generic over value type and store actual values in Append operations instead of offsets |
| storage/src/adb/keyless.rs | Restructured storage to use values journal for operations and locations journal for offsets, enabling proper authentication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dbf3b0a to
7047b2c
Compare
4a6feed to
9b9eaf6
Compare
| /// The locations structure provides the "source of truth" for the db's pruning boundaries and | ||
| /// overall size, should there be any discrepancies. | ||
| locations: FJournal<E, Operation>, | ||
| locations: FJournal<E, u32>, |
There was a problem hiding this comment.
Cool we can use u32 directly now 🚀
patrick-ogrady
approved these changes
Aug 19, 2025
roberto-bayardo
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were incorrectly putting offsets instead of values into the authenticated portion. Moves the operation type from locations to the values journal so that proving works identically to other stores.