Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BrendanChou
Copy link
Collaborator

Fixes #1487

@patrick-ogrady
Copy link
Contributor

patrick-ogrady commented Aug 27, 2025

As discussed offline, this would make more sense if we compressed across messages (as digests would likely be repeated many times). However, item-by-item compression in this context won't help much (or at all).

@patrick-ogrady patrick-ogrady merged commit b8f3430 into main Aug 27, 2025
37 checks passed
@patrick-ogrady patrick-ogrady deleted the bc/1487-consensus-compression branch August 27, 2025 21:11
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.72%. Comparing base (bb26817) to head (27c6e31).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         280      280              
  Lines       70616    70579      -37     
==========================================
- Hits        64776    64740      -36     
+ Misses       5840     5839       -1     
Files with missing lines Coverage Δ
consensus/src/simplex/actors/voter/actor.rs 91.48% <100.00%> (-0.01%) ⬇️
consensus/src/simplex/actors/voter/mod.rs 98.29% <ø> (-0.01%) ⬇️
consensus/src/simplex/config.rs 68.75% <ø> (ø)
consensus/src/simplex/engine.rs 94.50% <ø> (-0.06%) ⬇️
consensus/src/simplex/mod.rs 98.20% <ø> (-0.02%) ⬇️
...sensus/src/threshold_simplex/actors/voter/actor.rs 93.10% <100.00%> (-0.01%) ⬇️
...onsensus/src/threshold_simplex/actors/voter/mod.rs 98.21% <ø> (-0.01%) ⬇️
consensus/src/threshold_simplex/config.rs 68.75% <ø> (ø)
consensus/src/threshold_simplex/engine.rs 92.06% <ø> (-0.07%) ⬇️
consensus/src/threshold_simplex/mod.rs 98.66% <ø> (-0.01%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb26817...27c6e31. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[consensus] Remove compression option from consensus engines

2 participants