Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@BrendanChou
Copy link
Collaborator

Fixes #409

@BrendanChou BrendanChou force-pushed the bc/409-passive-consensus branch from 29e8fab to 5c042a0 Compare August 28, 2025 21:56
@BrendanChou BrendanChou marked this pull request as ready for review August 29, 2025 15:00
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

@patrick-ogrady patrick-ogrady merged commit 1931214 into main Aug 29, 2025
37 checks passed
@patrick-ogrady patrick-ogrady deleted the bc/409-passive-consensus branch August 29, 2025 17:59
@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.91%. Comparing base (b8f3430) to head (44b0f90).
⚠️ Report is 11 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
+ Coverage   91.72%   91.91%   +0.19%     
==========================================
  Files         280      280              
  Lines       70579    71283     +704     
==========================================
+ Hits        64739    65523     +784     
+ Misses       5840     5760      -80     
Files with missing lines Coverage Δ
consensus/src/simplex/actors/voter/actor.rs 91.48% <100.00%> (ø)
consensus/src/simplex/mod.rs 98.31% <100.00%> (+0.10%) ⬆️
...sensus/src/threshold_simplex/actors/voter/actor.rs 93.12% <100.00%> (+0.01%) ⬆️
...onsensus/src/threshold_simplex/actors/voter/mod.rs 98.24% <100.00%> (+0.03%) ⬆️
...onsensus/src/threshold_simplex/mocks/supervisor.rs 77.03% <100.00%> (ø)
consensus/src/threshold_simplex/mod.rs 98.74% <100.00%> (+0.08%) ⬆️

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f3430...44b0f90. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[consensus] Test that non-participants can run consensus engines

3 participants