Remove unnecessary clone() in wire message test #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
approved these changes
Sep 2, 2025
patrick-ogrady
approved these changes
Sep 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1518 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 283 283
Lines 73159 73159
=======================================
Hits 67355 67355
Misses 5804 5804
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates redundant clone() call in test_codec_response() since the encoded variable is not used after Message::decode().