[cryptography] Use CryptoRng consistently #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad154c5 to
e4cf9e2
Compare
patrick-ogrady
approved these changes
Sep 3, 2025
patrick-ogrady
requested changes
Sep 3, 2025
cryptography/Cargo.toml
Outdated
| bytes = { workspace = true } | ||
| thiserror = { workspace = true } | ||
| rand = { workspace = true } | ||
| rand = { workspace = true, features = ["std_rng"] } |
There was a problem hiding this comment.
for no_std, I think we explicitly enable this feature later?
There was a problem hiding this comment.
Yeah, I think this might've slipped through.
e4cf9e2 to
5adf27f
Compare
Closes #1088. This also modifies things to avoid the use of `Rng`, preferring `RngCore` instead (just within this crate), and the use of `RngCore + CryptoRng` to instead use `CryptoRngCore`.
5adf27f to
f994887
Compare
patrick-ogrady
approved these changes
Sep 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1542 +/- ##
========================================
Coverage 92.06% 92.07%
========================================
Files 283 284 +1
Lines 73182 73354 +172
========================================
+ Hits 67378 67541 +163
- Misses 5804 5813 +9
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1088.
This also modifies things to avoid the use of
Rng, preferringRngCoreinstead (just within this crate), and the use ofRngCore + CryptoRngto instead useCryptoRngCore.