-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[OPIK-4325] [FE] Sync prompt view components across Trace View and Prompt Library #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-4325] [FE] Sync prompt view components across Trace View and Prompt Library #5128
Conversation
|
🔄 Test environment deployment process has started Phase 1: Deploying base version You can monitor the progress here. |
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Outdated
Show resolved
Hide resolved
...frontend/src/components/pages-shared/traces/TraceDetailsPanel/TraceDataViewer/PromptsTab.tsx
Outdated
Show resolved
Hide resolved
apps/opik-frontend/src/components/pages/PromptPage/PromptTab/TextPromptView.tsx
Outdated
Show resolved
Hide resolved
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
a26ed0e to
c316f24
Compare
aadereiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it comes to functionality, works fine :) A good improvement. However, I've mentioned some code improvements that I think should be tackled before merging it
Let me know if you have any questions
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Show resolved
Hide resolved
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Show resolved
Hide resolved
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Outdated
Show resolved
Hide resolved
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Outdated
Show resolved
Hide resolved
apps/opik-frontend/src/components/pages/PromptPage/PromptTab/TextPromptView.tsx
Outdated
Show resolved
Hide resolved
apps/opik-frontend/src/components/pages/PromptPage/PromptTab/TextPromptView.tsx
Outdated
Show resolved
Hide resolved
aadereiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the comments! Good work :)
59c0447 to
39995a5
Compare
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Show resolved
Hide resolved
...frontend/src/components/pages-shared/traces/TraceDetailsPanel/TraceDataViewer/PromptsTab.tsx
Outdated
Show resolved
Hide resolved
...frontend/src/components/pages-shared/traces/TraceDetailsPanel/TraceDataViewer/PromptsTab.tsx
Outdated
Show resolved
Hide resolved
|
🔄 Test environment deployment process has started Phase 1: Deploying base version You can monitor the progress here. |
...k-frontend/src/components/pages-shared/llm/PromptMessagesReadonly/PromptMessagesReadonly.tsx
Outdated
Show resolved
Hide resolved
apps/opik-frontend/src/components/pages-shared/llm/PromptTemplateView/PromptTemplateView.tsx
Outdated
Show resolved
Hide resolved
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
293283b to
b798f18
Compare
apps/opik-frontend/src/components/pages/PromptPage/PromptTab/PromptTab.tsx
Show resolved
Hide resolved
SDK E2E Tests Results172 tests 169 ✅ 5m 0s ⏱️ For more details on these failures, see this check. Results for commit bd8e21f. ♻️ This comment has been updated with latest results. |
...d/src/components/pages-shared/traces/TraceDetailsPanel/TraceDataViewer/PromptContentView.tsx
Show resolved
Hide resolved
...frontend/src/components/pages-shared/traces/TraceDetailsPanel/TraceDataViewer/PromptsTab.tsx
Show resolved
Hide resolved
aadereiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you for addressing the comments :)
…ompt Library (#5128) * Adjust prompt library * Adjust Trace View Prompts tab * address comments * Address comments * Address design review * fix * Address comments * fix * fix * address comments * address comments * address comment * fix * address comments * align padding * address comment * address comment * fix linting * fix * fix comments
Details
This PR unifies the prompt display components across different parts of the application to ensure consistency between the Trace View Prompts tab and the Prompt Library.
Screen.Recording.2026-02-09.at.10.44.44.mov
Key changes:
PromptMessagesReadonlycomponent that handles displaying chat messages with proper role labels and media attachments (images, videos, audios)TextPromptViewin the Prompt Library to use the same message card display for JSON message arraysChatPromptMessageReadonlyto use the sharedPromptMessageCardcomponentChatPromptAttachmentscomponent in favor of inline media renderingChange checklist
Issues
Testing
Documentation
N/A