Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix deprecation notice #10921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Fix deprecation notice #10921

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6705538
Fix deprecation notice
fluffycondor Jul 4, 2022
4209bf1
Fix syntax for PHP 5
fluffycondor Jul 4, 2022
c61f419
Fix possibly empty token
fluffycondor Jul 4, 2022
9db51ec
Cast null to an empty string
fluffycondor Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Composer/Util/GitHub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ public function authorizeOAuthInteractively($originUrl, $message = null)
$this->io->writeError(sprintf('Tokens will be stored in plain text in "%s" for future use by Composer.', $this->config->getAuthConfigSource()->getName()));
$this->io->writeError('For additional information, check https://getcomposer.org/doc/articles/authentication-for-private-packages.md#github-oauth');

$token = trim($this->io->askAndHideAnswer('Token (hidden): '));
$token = trim((string) $this->io->askAndHideAnswer('Token (hidden): '));

if (!$token) {
if ($token === '') {
$this->io->writeError('<warning>No token given, aborting.</warning>');
$this->io->writeError('You can also add it manually later by using "composer config --global --auth github-oauth.github.com <token>"');

Expand Down