Added CheckPlatformReqsCommand Test #11079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Oct 12, 2022
Comment on lines
+113
to
+121
| 'composerJson' => [ | ||
| 'require' => [ | ||
| 'first/pkg' => '^2.0', | ||
| 'second/pkg' => '3.*', | ||
| ], | ||
| 'require-dev' => [ | ||
| 'dev/pkg' => '~2.0', | ||
| ], | ||
| ], |
Member
There was a problem hiding this comment.
This is lots of duplication and cruft as these are entirely unnecessary to run this test. Would be nice to reduce duplication at least.
Seldaek
reviewed
Oct 12, 2022
Comment on lines
+47
to
+55
| 'composerJson' => [ | ||
| 'require' => [ | ||
| 'first/pkg' => '^2.0', | ||
| 'second/pkg' => '3.*', | ||
| ], | ||
| 'require-dev' => [ | ||
| 'dev/pkg' => '~2.0', | ||
| ], | ||
| ], |
Member
There was a problem hiding this comment.
Lots of duplication here too, and it doesn't seem to provide much value as you only check the first line of output.
It'd be more valuable to actually check behavior i.e. make sure that the installed packages above in testCheckPlatformReqs have some requirements on platform and then check that the output is pass or fail depending if it's a valid requirement or not.
Contributor
Author
There was a problem hiding this comment.
Okay I will work on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.