Fix null-removal on nested captured-arrays #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 22, 2024
| $matchesType = new ConstantArrayType( | ||
| $matchesType->getKeyTypes(), | ||
| array_map(static function (Type $valueType): Type { | ||
| if (count($valueType->getConstantArrays()) === 1) { |
There was a problem hiding this comment.
when PREG_OFFSET_CAPTURE the $valueType is again a constant-array-type.
TypeCombinator::removeNull does not deep iterate into arrays
There was a problem hiding this comment.
I used the same logic already arround, but I guess we will get problems in the future with it when patterns are used which return more then 1 constant array (maybe one of the tagged union cases)
There was a problem hiding this comment.
we could use https://github.com/phpstan/phpstan-src/blob/1.12.x/src/Type/TypeTraverser.php instead
|
Thanks, that solves it for replaceCallbackStrictGroups I think. The problem with isMatchAllStrictGroups and matchAllStrictGroups from #34 is still there tho right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #34 (comment)