Feature/file dir.remove #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing and created boilerplate in dir remove
|
Just run a quick |
|
Thank you for looking at this pr. I just ran fmt --all and pushed it. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 28.03% 28.59% +0.55%
==========================================
Files 80 84 +4
Lines 2197 2263 +66
==========================================
+ Hits 616 647 +31
- Misses 1581 1616 +35
☔ View full report in Codecov by Sentry. |
|
Feel free to let me know if there is anything I need to do to get this branch merged, and I'll get it done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the current behavior?
There is today no way of deleting files and folders.
What is the expected behavior?
You can now remove files and directories using the action: file.remove or directory/dir.remove.
Let me know if there is anything you want to be done in a different way, and ill fix it up.
What is the motivation / use case for changing the behavior?
#268
Please tell us about your environment:
Version (
0.8.4):Operating system: Fedora 37