Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@martintc
Copy link
Member

@martintc martintc commented Sep 2, 2024

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Package providers are not able to utilize local package files (such as .deb for apt and .pkg for FreeBSD's pkg) with a system's package manager.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Not a bug.

What is the expected behavior?

For this PR. Just to implement the first package provider, FreeBSD's pkg, with this feature.

Here is a sample manifest:

actions:
  - action: package.install
    name: ./examples/test/nano-8.1.pkg
    file: true    

As of this PR, true will be required. I will create an issue for creating the ability to detect if its a file versus not a file.

What is the motivation / use case for changing the behavior?

See issue #430

Please tell us about your environment:

Version (comtrya --version): v.0.8.9
Operating system: FreeBSD 14.1

@martintc martintc changed the title intial code for feature intial code for feature for local package installs Sep 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 26.85%. Comparing base (b574682) to head (b721aae).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/actions/package/providers/bsdpkg.rs 0.00% 11 Missing ⚠️
lib/src/actions/package/install.rs 0.00% 5 Missing ⚠️
lib/src/actions/package/mod.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   28.59%   26.85%   -1.75%     
==========================================
  Files          85       83       -2     
  Lines        2301     2264      -37     
==========================================
- Hits          658      608      -50     
- Misses       1643     1656      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonas
Copy link
Contributor

yonas commented Sep 2, 2024

Thanks! Works for me. 🎉

@martintc martintc merged commit f3d5b80 into comtrya:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants