Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Append file name to target if target is a directory #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2024
Merged

Append file name to target if target is a directory #463

merged 4 commits into from
Sep 10, 2024

Conversation

@martintc
Copy link
Member

@martintc martintc commented Sep 10, 2024 •
edited
Loading

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

File copy fails when to is a directory.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

actions:
  - action: file.copy
    from: sample.txt
    to: /tmp/

What is the expected behavior?

This action to pass with comtrya appending the file name to the target

What is the motivation / use case for changing the behavior?

#315

Please tell us about your environment:

Version (comtrya --version): v0.8.9
Operating system: macOS 14.6.1

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.45%. Comparing base (b574682) to head (965a9ba).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/actions/file/copy.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   28.59%   26.45%   -2.15%     
==========================================
  Files          85       83       -2     
  Lines        2301     2310       +9     
==========================================
- Hits          658      611      -47     
- Misses       1643     1699      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintc martintc merged commit 4dd3256 into comtrya:main Sep 10, 2024
6 checks passed
@martintc martintc deleted the file-copy-to-dir branch September 10, 2024 05:04
@martintc martintc mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martintc @codecov-commenter