Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yonas
Copy link
Contributor

@yonas yonas commented Sep 14, 2024

I'm submitting a

  • bug fix
  • [] feature
  • documentation addition

What is the current behaviour?

The deploy mdbook workflow fails in my fork because I don't have permission to publish.

It would be great to see that all tests pass / fail when looking at my fork commit history without having to account for the deploy workflow always failing.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.42%. Comparing base (b574682) to head (037094a).
Report is 46 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   28.59%   26.42%   -2.17%     
==========================================
  Files          85       83       -2     
  Lines        2301     2312      +11     
==========================================
- Hits          658      611      -47     
- Misses       1643     1701      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonas yonas force-pushed the yonas-deploy-mdbook branch 4 times, most recently from 6208e33 to 32c3573 Compare September 14, 2024 14:58
@yonas yonas force-pushed the yonas-deploy-mdbook branch from 32c3573 to 037094a Compare September 14, 2024 15:03
@martintc
Copy link
Member

I definitely overlooked the pipeline running in forks causing an annoying failure. Thanks for the PR to fix that!

@martintc martintc merged commit eb6db27 into comtrya:main Sep 14, 2024
6 checks passed
@martintc
Copy link
Member

Looks like there is an issue with it. I tried messing with the dependencies to see if maybe the upload step needed to depend on the build step and deploy step depend on the upload, but that wasn't quiet it either.

@yonas yonas deleted the yonas-deploy-mdbook branch September 23, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants