Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@knelasevero
Copy link
Contributor

Hey! Very cool project! πŸ˜„

Was setting up an old laptop at home and came across this very promising project. My wife and I are using Arch/Manjaro and having support to yay/pacman would be great!

@knelasevero knelasevero changed the title Add yay provider feat: Add yay provider Mar 20, 2021
@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Hey. Thanks for the PR. I'll get that code coverage action disabled on forks, that's never going to work because of the secret.

The bootstrap function uses pacman to install Yay, but it's only available in the AUR (maybe different on Manjaro?). I'm actually OK with the bootstrap returning an error for now and leaving a message that says to manually install yay, as it's not easy to coordinate multiple steps with command execution yet, or raise privilege; though this will be ready by tomorrow #50

Thanks again πŸ˜€

@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Closes #16

@knelasevero
Copy link
Contributor Author

You are right! Forgot that in a pure arch box you have some extra steps to have an AUR helper available πŸ˜…

I added more commands if you want to merge this one before the command privilege escalation PR. I can also wait for the other one to get merged and rebase it here if you prefer :)

Tested this in a pure Arch machine and it seems to work.

@knelasevero knelasevero force-pushed the feature/yay_provider branch from 95e10f4 to c49bde5 Compare March 21, 2021 11:40
@knelasevero
Copy link
Contributor Author

Saw that you merged it just now, already rebased it here and started using the new command approach

@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Damn, that was fast! The new run_command helper should be much easier for supporting new providers like this. I'll get this merged when you're happy with it πŸ˜€

@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Sorry, I didn't realise you were new to Rust. I've gone through and tried to identify all the little pesky mistakes.

Let me know if you want me to push any fixes instead πŸ‘πŸ»

@knelasevero
Copy link
Contributor Author

Sorry, I didn't realise you were new to Rust. I've gone through and tried to identify all the little pesky mistakes.

Let me know if you want me to push any fixes instead πŸ‘πŸ»

Thanks! Yeah, only touched Rust before in Advent of code challenges πŸ˜„ Gonna eat something and fix all the details!

@knelasevero
Copy link
Contributor Author

Also sorry for Pushing code with compilation errors. I am pulling this in a fresh vm to test in a place without the AUR helper πŸ˜… gonna tidy up in a bit

@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Also sorry for Pushing code with compilation errors. I am pulling this in a fresh vm to test in a place without the AUR helper πŸ˜… gonna tidy up in a bit

Not a problem, I'm here if you need any help. Have fun!

@knelasevero knelasevero force-pushed the feature/yay_provider branch 2 times, most recently from 865a33b to 7e37a7f Compare March 21, 2021 16:32
@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Are you happy with this now?

@knelasevero
Copy link
Contributor Author

Are you happy with this now?

I am happy :) I think that after CI we can merge. Thanks for reviewing @rawkode!

@rawkode
Copy link
Member

rawkode commented Mar 21, 2021

Perfect. I'll dig in to the sudo thing this evening. Thanks for the awesome PR

@rawkode rawkode merged commit 86feefb into comtrya:main Mar 21, 2021
@rawkode
Copy link
Member

rawkode commented Mar 25, 2021

Stupid bug on my part, which I believe caused the errors you mentioned. Sorry about that!

dabfb77

@knelasevero

@knelasevero
Copy link
Contributor Author

😹 no worries! Cool that you found it!

@knelasevero knelasevero deleted the feature/yay_provider branch March 25, 2021 10:05
@knelasevero
Copy link
Contributor Author

Btw, @rawkode , if you need anything tested on arch I can happily do that here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants