-
Notifications
You must be signed in to change notification settings - Fork 55
feat: Add yay provider #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey. Thanks for the PR. I'll get that code coverage action disabled on forks, that's never going to work because of the secret. The bootstrap function uses pacman to install Yay, but it's only available in the AUR (maybe different on Manjaro?). I'm actually OK with the bootstrap returning an error for now and leaving a message that says to manually install yay, as it's not easy to coordinate multiple steps with command execution yet, or raise privilege; though this will be ready by tomorrow #50 Thanks again π |
|
Closes #16 |
|
You are right! Forgot that in a pure arch box you have some extra steps to have an AUR helper available π I added more commands if you want to merge this one before the command privilege escalation PR. I can also wait for the other one to get merged and rebase it here if you prefer :) Tested this in a pure Arch machine and it seems to work. |
95e10f4 to
c49bde5
Compare
|
Saw that you merged it just now, already rebased it here and started using the new command approach |
|
Damn, that was fast! The new |
|
Sorry, I didn't realise you were new to Rust. I've gone through and tried to identify all the little pesky mistakes. Let me know if you want me to push any fixes instead ππ» |
Thanks! Yeah, only touched Rust before in Advent of code challenges π Gonna eat something and fix all the details! |
|
Also sorry for Pushing code with compilation errors. I am pulling this in a fresh vm to test in a place without the AUR helper π gonna tidy up in a bit |
Not a problem, I'm here if you need any help. Have fun! |
865a33b to
7e37a7f
Compare
|
Are you happy with this now? |
I am happy :) I think that after CI we can merge. Thanks for reviewing @rawkode! |
|
Perfect. I'll dig in to the sudo thing this evening. Thanks for the awesome PR |
|
Stupid bug on my part, which I believe caused the errors you mentioned. Sorry about that! |
|
πΉ no worries! Cool that you found it! |
|
Btw, @rawkode , if you need anything tested on arch I can happily do that here ;) |
Hey! Very cool project! π
Was setting up an old laptop at home and came across this very promising project. My wife and I are using Arch/Manjaro and having support to yay/pacman would be great!