Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test against Python 3.10 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yarikoptic merged 2 commits into from
Jan 26, 2022
Merged

Test against Python 3.10 #136

yarikoptic merged 2 commits into from
Jan 26, 2022

Conversation

@jwodder
Copy link
Contributor

@jwodder jwodder commented Oct 7, 2021

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label Oct 7, 2021
@jwodder
Copy link
Contributor Author

jwodder commented Oct 7, 2021

It seems that Travis and Appveyor don't support Python 3.10 yet.

@yarikoptic
Copy link
Member

yarikoptic commented Jan 11, 2022

also typing checks aren't happy with

test/test_state.py:60: error: Statement is unreachable  [unreachable]
        assert statefile.modified
        ^
test/test_state.py:88: error: Statement is unreachable  [unreachable]
        with open(STATE_FILE) as fp:
        ^
test/test_state.py:127: error: Statement is unreachable  [unreachable]
        with f.open() as fp:
        ^
test/test_state.py:164: error: Statement is unreachable  [unreachable]
        with f.open() as fp:
        ^
Found 4 errors in 1 file (checked 13 source files)

@jwodder
Copy link
Contributor Author

jwodder commented Jan 11, 2022

@yarikoptic That's addressed by #142.

@yarikoptic
Copy link
Member

yarikoptic commented Jan 26, 2022

time to refresh this PR and get it green?

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #136 (e91f4de) into master (ba72e85) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   70.87%   70.73%   -0.15%     
==========================================
  Files          10       10              
  Lines         975      984       +9     
  Branches      179      184       +5     
==========================================
+ Hits          691      696       +5     
- Misses        230      232       +2     
- Partials       54       56       +2
Impacted Files Coverage Δ
src/tinuous/base.py 80.12% <66.66%> (-1.41%) ⬇️
src/tinuous/__main__.py 52.08% <0.00%> (-1.39%) ⬇️
src/tinuous/appveyor.py 75.29% <0.00%> (-0.90%) ⬇️
src/tinuous/travis.py 63.06% <0.00%> (-0.58%) ⬇️
src/tinuous/github.py 53.53% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5031198...e91f4de. Read the comment docs.

@jwodder
Copy link
Contributor Author

jwodder commented Jan 26, 2022

@yarikoptic Tests are all green now.

@yarikoptic
Copy link
Member

yarikoptic commented Jan 26, 2022

awesome, let's proceed. thank you!

@yarikoptic yarikoptic merged commit a2b297e into master Jan 26, 2022
@yarikoptic yarikoptic deleted the py3.10 branch January 26, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests Add or improve existing tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jwodder @yarikoptic @codecov-commenter