Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[AutotoolsToolchain] Improve update_xxxxx_args behavior #12889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 11, 2023
Merged

[AutotoolsToolchain] Improve update_xxxxx_args behavior #12889

merged 12 commits into from
Jan 11, 2023

Conversation

@franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Jan 11, 2023 •
edited
Loading

Changelog: Feature: AutotoolsToolchain helper functions: update_configure_args, update_make_args, and update_autoreconf_args can also add new values
Docs: conan-io/docs#2895

Summary: before this change, it was only possible to update/remove existing values. Now, you could add new ones. Trying to avoid weird situations like:

        tc = AutotoolsToolchain(self)
        tc.configure_args.extend([
            "--datarootdir=${prefix}/lib", # do not use share
            "--disable-layoutex",
            "--disable-layout"])
        tc.update_configure_args({"--force": None})

After my change, then it could be reduced to:

        tc = AutotoolsToolchain(self)
        tc.update_configure_args({
            "--force": None,
            "--datarootdir": "${prefix}/lib", # do not use share
            "--disable-layoutex": "",
            "--disable-layout": ""})

Both are working, but I think the latest one could be the expected behavior. WDYT?

@franramirez688 franramirez688 added this to the 1.57 milestone Jan 11, 2023
memsharded
memsharded approved these changes Jan 11, 2023
View reviewed changes
@franramirez688 franramirez688 mentioned this pull request Jan 11, 2023
Merged
@czoido czoido merged commit 33aec0b into conan-io:release/1.57 Jan 11, 2023
@franramirez688 franramirez688 mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@memsharded memsharded memsharded approved these changes

@czoido czoido czoido approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@czoido czoido

Labels

None yet

Projects

None yet

Milestone

1.57

Development

Successfully merging this pull request may close these issues.

4 participants

@franramirez688 @czoido @AbrilRBS @memsharded