Thanks to visit codestin.com
Credit goes to github.com

Skip to content

change default for source_buildenv, too risky #15319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

change default for source_buildenv, too risky #15319

merged 1 commit into from
Dec 21, 2023

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Dec 21, 2023 •
edited by czoido
Loading

Changelog: Bugfix: Revert the default of source_buildenv, make it False by default.
Docs: conan-io/docs#3501

Close #15317

It might require future work to correctly propagate conf to the source() step too

@memsharded memsharded added this to the 2.0.16 milestone Dec 21, 2023
@AbrilRBS
Copy link
Member

AbrilRBS commented Dec 21, 2023

Oh, I see. 🍔

@czoido czoido merged commit 1bd3f2a into conan-io:release/2.0 Dec 21, 2023
@memsharded memsharded deleted the fix/default_source_buildenv branch December 21, 2023 09:47
This was referenced Dec 21, 2023
Merged
Closed
@czoido czoido mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czoido czoido czoido approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@czoido czoido

Labels

type: look into

Projects

None yet

Milestone

2.0.16

Development

Successfully merging this pull request may close these issues.

[bug] "ERROR: win_bash=True but tools.microsoft.bash:subsystem configuration not defined" even though it's defined by a build requirement

3 participants

@memsharded @AbrilRBS @czoido