Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set __win version to platform.version when available, allowing overrides #14450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 8, 2025
Merged

Set __win version to platform.version when available, allowing overrides #14450

merged 9 commits into from
Jan 8, 2025
+60 −5

Conversation

@jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Dec 17, 2024 •
edited
Loading

Description

Closes #14443

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 17, 2024
@jaimergp jaimergp mentioned this pull request Dec 17, 2024
Closed
2 tasks
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #14450 will not alter performance

Comparing jaimergp:win-virtual-package-version (190cc18) with main (14483be)

Summary

✅ 21 untouched benchmarks

@jaimergp
Copy link
Contributor Author

jaimergp commented Dec 17, 2024

Accompanying CEP at conda/ceps#103

jaimergp
jaimergp commented Jan 7, 2025
View reviewed changes
@jaimergp jaimergp marked this pull request as ready for review January 7, 2025 15:14
@jaimergp jaimergp requested a review from a team as a code owner January 7, 2025 15:14
@jaimergp
Copy link
Contributor Author

jaimergp commented Jan 7, 2025

@conda/conda-maintainers, this is ready to go! Very similar to #14449 and following recommendations in conda/ceps#103

@jaimergp jaimergp merged commit 7d075cf into conda:main Jan 8, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenodegard kenodegard kenodegard approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

🔎 Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ENH: make __win version usable for package metadata

3 participants

@jaimergp @kenodegard @conda-bot