CodSpeed Performance Report

Merging #14510 will not alter performance

_{Comparing travishathaway:issue-13661 (1ce4f4d) with main (91895ab)}

Summary

✅ 21 untouched benchmarks

Getting very close with this one. I think I only need to implement the correct behavior for conda config --show and conda config --show-sources.

I'm working through some changes currently..

@kenodegard,

I appreciate the review, and you have importantly pointed to some gaps in coverage we have (more on that later). But, while the review is appreciated, I do have some problems with your example above. Please allow me to explain...

While I do concede that the above does fail, in your example, the _key_exists function is not being used in the correct context. On the Context class, parameters are special types of objects (ParameterLoader). Because of this, plugins will never be returned by the list_parameters method and when that's true, the _key_exists function works as expected.

A more realistic example for how the Configuration classes are being used in conda would be the following:

import os
from argparse import Namespace
from conda.cli.main_config import _key_exists
from conda.common.configuration import (
    Configuration, ParameterLoader, PrimitiveParameter
)
from conda.plugins.config import PluginConfig

class Plugins(PluginConfig):
    baz = ParameterLoader(PrimitiveParameter("default"))

class Context(Configuration):
    foo = ParameterLoader(PrimitiveParameter(True))
    json = ParameterLoader(PrimitiveParameter(True))

    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self._set_env_vars("TESTER")

    @property
    def plugins(self):
        return Plugins(self.raw_data)

class Args(Namespace):
    foo: bool
    json: bool

# Plugin configuration values can only come from environment variables
# or config files
os.environ["TESTER_PLUGINS_BAZ"] = "something"

args = Args(foo=False, json=False)
context = Context(argparse_args=args)

assert context.plugins.baz == "something"
assert not context.foo
assert not context.json

assert _key_exists("foo", [], context) # passes
assert _key_exists("plugins.baz", [], context) # passes

assert not _key_exists("missing", [], context) # passes
assert not _key_exists("plugins.missing", [], context) # passes

After writing the above example, I realized that _key_exists is not being directly tested in our test suite. Thanks for helping point this out. To address this, I added the following test to our test suite. See the commit below for details:

• df07755

I hope this can convince you that this pull request is ready to be merged. If you have any more concerns, I'm happy to hear them.

@kenodegard Do you have major concerns about the current state of this PR?