Fixes PowerShell 7.5.0 environment activation #14517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #14517 will not alter performanceComparing Summary
|
91b9bba to
bbea40b
Compare
bbea40b to
dfbf566
Compare
cad7310 to
22ad933
Compare
|
Confirming that installing PowerShell 7.5.0 and parameterizing the applicable tests replicates the issue: https://github.com/conda/conda/actions/runs/12999890671/job/36256153948?pr=14517 |
e97762e to
ed8692b
Compare
ed8692b to
97e835d
Compare
jezdez
reviewed
Jan 28, 2025
Comment on lines
+4
to
+9
| if [ -n "${_CE_M:+x}" ] && [ -n "${_CE_CONDA:+x}" ]; then | ||
| # only use _CE_M/_CE_CONDA when defined to avoid issues when run with `set -u` | ||
| "$CONDA_EXE" $_CE_M $_CE_CONDA "$@" | ||
| else | ||
| "$CONDA_EXE" "$@" | ||
| fi |
There was a problem hiding this comment.
This makes sense I think, looks awfully something like I've seen before in conda, can't put my finger on it though
jezdez
approved these changes
Jan 28, 2025
kenodegard
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
Closed
|
When will this ship? |
1 task
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #14514
Fixes: #14292
This is a suggested proposal for addressing the two issue above. I have tested this locally so far with PowerShell 7.5.0 and it appears to be working. Needs more extensive testing though.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?