Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not use IndexedSet for deduplication #14777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

Do not use IndexedSet for deduplication #14777

merged 2 commits into from
Apr 22, 2025
+23 −5

Conversation

@jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Apr 22, 2025 •
edited
Loading

Description

Noticed this unnecessary IndexedSet incursions when all we need is dict.fromkeys for deduplication. I initially saw this in #14776 and thought it would be more widespread, so that's why I started in this branch, but to my surprise that's everything.

We do have a lot of (indiscriminate?) IndexedSet usage but I won't touch the apparently legitimate cases here. Just the tuple(IndexedSet(...)) bits.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 22, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Apr 22, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 22, 2025

CodSpeed Performance Report

Merging #14777 will not alter performance

Comparing jaimergp:indexedset-dictfromkeys (cc53cde) with main (c3f1b39)

Summary

✅ 21 untouched benchmarks

@jaimergp jaimergp moved this to In Progress 🏗️ in Quansight <> Anaconda 2025 Apr 22, 2025
@jaimergp jaimergp marked this pull request as ready for review April 22, 2025 17:34
@jaimergp jaimergp requested a review from a team as a code owner April 22, 2025 17:34
@jjhelmus
Copy link
Contributor

Why use dict.fromkeys which requires an intermediate dict instance over set?

@jjhelmus
Copy link
Contributor

Answering my own question, set does not guarantee that the order of elements is preserved, dict.fromkeys does.

@jjhelmus
Copy link
Contributor

unique_iter from boltons.iterutils is another option as a replacement. Depends on if the goal is clarity or removing the use of boltons.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review Apr 22, 2025
@jaimergp
Copy link
Contributor Author

Depends on if the goal is clarity or removing the use of boltons.

I'm slowly trying to get rid of boltons when there are (now) Python idioms that maybe didn't exist back when the code was written. e.g. dict didn't have guaranteed insertion order til recently.

@jaimergp jaimergp merged commit 25e84ca into conda:main Apr 22, 2025
76 checks passed
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done 💪🏾 in Quansight <> Anaconda 2025 Apr 22, 2025
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Apr 22, 2025
@kenodegard
Copy link
Contributor

I'm 100% on board with this, just FYI we also have conda.common.iterators.unique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjhelmus jjhelmus jjhelmus approved these changes

Assignees

No one assigned

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

🔎 Review
Archived in project
Quansight <> Anaconda 2025
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaimergp @jjhelmus @kenodegard @conda-bot