fix TypeError: can only concatenate tuple (not "list") to tuple#15026
Merged
kenodegard merged 5 commits intoconda:mainfrom Jul 21, 2025
Merged
fix TypeError: can only concatenate tuple (not "list") to tuple#15026kenodegard merged 5 commits intoconda:mainfrom
TypeError: can only concatenate tuple (not "list") to tuple#15026kenodegard merged 5 commits intoconda:mainfrom
Conversation
3 tasks
CodSpeed Instrumentation Performance ReportMerging #15026 will not alter performanceComparing Summary
Footnotes |
kenodegard
previously approved these changes
Jul 21, 2025
kenodegard
reviewed
Jul 21, 2025
soapy1
previously approved these changes
Jul 21, 2025
Contributor
soapy1
left a comment
There was a problem hiding this comment.
It looks like the root of this issue is the EnvironmentYaml env spec plugin is not respecting the type annotations of the EnvironmentConfig class. I think this change is ok to make the model more resilient, but I think it would also be helpful to update the EnvironmentYaml plugin to return the correct type.
Can we do that in this PR as well? https://github.com/conda/conda/blob/main/conda/env/env.py#L271 needs to be updated to be config = EnvironmentConfig(channels=tuple(self.channels)).
Co-authored-by: Ken Odegard <[email protected]>
Co-authored-by: Sophia Castellarin <[email protected]>
Contributor
Author
|
Thanks @soapy1 @kenodegard, I applied your suggestions! |
soapy1
approved these changes
Jul 21, 2025
kenodegard
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small fix for some environment files in #14911. Reproduces with:
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?