Remove deprecated code in conda.exports#15184
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
CodSpeed Instrumentation Performance ReportMerging #15184 will not alter performanceComparing Summary
|
tests/test_exports.py
Outdated
There was a problem hiding this comment.
Oh let's just do that immediately here?
tests/test_exports.py
Outdated
There was a problem hiding this comment.
| # TODO: will need to be re-enabled for `CondaJSONEncoder` deprecation warning in 26.3 | |
| # @pytest.mark.parametrize( | |
| # "function,raises", | |
| # [ | |
| # ("EntityEncoder", TypeError), | |
| # ], | |
| # ) | |
| # def test_deprecations(function: str, raises: type[Exception] | None) -> None: | |
| # raises_context = pytest.raises(raises) if raises else nullcontext() | |
| # with pytest.deprecated_call(), raises_context: | |
| # getattr(exports, function)() | |
| @pytest.mark.parametrize( | |
| "function,raises", | |
| [ | |
| ("EntityEncoder", TypeError), | |
| ], | |
| ) | |
| def test_deprecations(function: str, raises: type[Exception] | None) -> None: | |
| raises_context = pytest.raises(raises) if raises else nullcontext() | |
| with pytest.deprecated_call(), raises_context: | |
| getattr(exports, function)() |
There was a problem hiding this comment.
As of right now, this test will fail. I belive this error message will start appearing in release 26.3 https://github.com/conda/conda/blob/main/conda/exports.py#L120
There was a problem hiding this comment.
The issue was just that EntityEncoder doesn't require any args so it doesn't raise a TypeError
All codes currently in any stage of the deprecation cycle will warn about the deprecation
|
As of today conda-build still references the removed |
Description
Remove deprecated methods, arguments and constants from
conda.exports.xref: #15116
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?