Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pbadani
Copy link
Member

@pbadani pbadani commented May 5, 2025

Description

Remove License validator overrides for tests.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

Copilot AI review requested due to automatic review settings May 5, 2025 04:54
@pbadani pbadani requested a review from a team as a code owner May 5, 2025 04:54
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the License validator overrides that were applied in tests.

  • Removed hard-coded License validator configuration properties
  • Simplified test configuration in KafkaEmbedded
Comments suppressed due to low confidence (1)

ksqldb-test-util/src/main/java/io/confluent/ksql/test/util/KafkaEmbedded.java:120

  • Ensure that removal of these test-specific license validator overrides does not negatively impact tests that may have depended on the previous configuration; update any dependent tests accordingly if needed.
    -    // License validator overrides for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants