Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alicefr
Copy link
Contributor

@alicefr alicefr commented Jul 25, 2022

The function readLVMConfig always returns an error.

Signed-off-by: Alice Frosi [email protected]

@alicefr alicefr force-pushed the fix-return-error branch from c97018c to ac4776e Compare July 25, 2022 07:44
@alicefr
Copy link
Contributor Author

alicefr commented Jul 25, 2022

This PR fixes the issue found in cri-o/cri-o#5624 (comment)

@alicefr
Copy link
Contributor Author

alicefr commented Jul 25, 2022

fyi @saschagrunert

The function readLVMConfig always returns an error.

Signed-off-by: Alice Frosi <[email protected]>
@alicefr alicefr force-pushed the fix-return-error branch from ac4776e to a010eb4 Compare July 25, 2022 07:52
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, another one
/lgtm

@saschagrunert
Copy link
Member

@containers/storage-maintainers PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit c9f85f7 into containers:main Jul 25, 2022
alicefr added a commit to alicefr/cri-o that referenced this pull request Jul 25, 2022
alicefr added a commit to alicefr/cri-o that referenced this pull request Jul 26, 2022
alicefr added a commit to alicefr/cri-o that referenced this pull request Aug 8, 2022
alicefr added a commit to alicefr/cri-o that referenced this pull request Aug 22, 2022
@alicefr alicefr deleted the fix-return-error branch August 23, 2022 06:31
alicefr added a commit to alicefr/cri-o that referenced this pull request Aug 23, 2022
alicefr added a commit to alicefr/cri-o that referenced this pull request Aug 24, 2022
Include fix github.com/containers/storage#1298

Signed-off-by: Alice Frosi <[email protected]>
alicefr added a commit to alicefr/cri-o that referenced this pull request Aug 25, 2022
Include fix github.com/containers/storage#1298

Signed-off-by: Alice Frosi <[email protected]>
alicefr added a commit to alicefr/cri-o that referenced this pull request Sep 1, 2022
Include fix github.com/containers/storage#1298

Signed-off-by: Alice Frosi <[email protected]>
alicefr added a commit to alicefr/cri-o that referenced this pull request Sep 6, 2022
Include fix github.com/containers/storage#1298

Signed-off-by: Alice Frosi <[email protected]>
alicefr added a commit to alicefr/cri-o that referenced this pull request Sep 8, 2022
Include fix github.com/containers/storage#1298

Signed-off-by: Alice Frosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants