-
Notifications
You must be signed in to change notification settings - Fork 267
fix return error in device mapper #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c97018c to
ac4776e
Compare
Contributor
Author
|
This PR fixes the issue found in cri-o/cri-o#5624 (comment) |
Contributor
Author
|
fyi @saschagrunert |
The function readLVMConfig always returns an error. Signed-off-by: Alice Frosi <[email protected]>
ac4776e to
a010eb4
Compare
saschagrunert
approved these changes
Jul 25, 2022
Member
saschagrunert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, another one
/lgtm
Member
|
@containers/storage-maintainers PTAL |
giuseppe
approved these changes
Jul 25, 2022
Member
giuseppe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Jul 25, 2022
Include fixes: - containers/storage#1294 - containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Jul 26, 2022
Include fixes: - containers/storage#1294 - containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Aug 8, 2022
Include fixes: - containers/storage#1294 - containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Aug 22, 2022
Include fixes: - containers/storage#1294 - containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Aug 23, 2022
Include fixes: - containers/storage#1294 - containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Aug 24, 2022
Include fix github.com/containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Aug 25, 2022
Include fix github.com/containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Sep 1, 2022
Include fix github.com/containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Sep 6, 2022
Include fix github.com/containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
alicefr
added a commit
to alicefr/cri-o
that referenced
this pull request
Sep 8, 2022
Include fix github.com/containers/storage#1298 Signed-off-by: Alice Frosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function readLVMConfig always returns an error.
Signed-off-by: Alice Frosi [email protected]