Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bowmande
Copy link

@bowmande bowmande commented Apr 8, 2016

Release Playbook

  • Rebase against master
  • Pass checks
  • Release branch ()
  • Pass CI ()
  • Code review
  • Merge into master
  • Release master ()
  • Pass CI ()
  • Update dev and testing racks
  • Publish release
  • Release CLI

allow users to run a command on a container for a given release

This allows user to build a release, then run commands such as
migrations then promote the release

Resolve #409

Drew Bowman added 2 commits April 7, 2016 21:21
allow users to run a command on a container for a given release

This allows user to build a release, then run commands such as
migrations then promote the release
@nzoschke
Copy link
Contributor

nzoschke commented Apr 8, 2016

👍 Thanks! Going to close this and test and release it on #530

@nzoschke nzoschke closed this Apr 8, 2016
@nzoschke nzoschke mentioned this pull request Apr 8, 2016
13 tasks
@nzoschke nzoschke reopened this Apr 8, 2016
@nzoschke
Copy link
Contributor

nzoschke commented Apr 8, 2016

I noticed in testing that this is working well w.r.t the older release images, but not the environment.

In reviewing this patch, I now see that it's copying environment from the current TaskDefinition.

It should be possible to use the Release EnvironmentUrl to get the encrypted release environment from S3, decrypt it and use that for the run.

@bowmande
Copy link
Author

bowmande commented Apr 8, 2016

Ok, Thanks, I'll update this!

@nzoschke
Copy link
Contributor

nzoschke commented Apr 8, 2016

Cool. I'm going to leave the existing commits in the release, we can patch on top of them in due time.

nzoschke pushed a commit that referenced this pull request Apr 9, 2016
#507 Build Provider Refactor
#496 warn if app contains unignored env
#514 don't panic on malformed labels
#529 Add support for passing existing IAM/ACM arn to convox ssl create/update commands
#526 run specific release
@snario
Copy link

snario commented May 16, 2016

I don't think this is working as expected, see below

$ convox run --detach --release RXOBADAUJUR frontend "webpack --progress --config webpack-prod.config.js"
Running `webpack --progress --config webpack-prod.config.jsa` on frontend... OK
$ convox ps
ID            NAME      RELEASE      SIZE  STARTED         COMMAND
f067a1c76125  frontend  RXOBADAUJUR  0     13 seconds ago  sh -c 'webpack --progress --config webpack-prod.config.js'
$ convox exec f067a1c76125 sh
$ /frontend # env
...
RELEASE=RZUUCAXHSZD

Shouldn't the RELEASE variable be the one specified by --release?

Workaround of course is to prefix the command with "RELEASE=RXOBADAUJUR webpack ..."

@nzoschke
Copy link
Contributor

@snario your expectation is correct around the RELEASE value.

Another patch is needed to correctly pick up the right environment for the specified release.

I do believe this is picking up the right docker images for the specified release. Did your test confirm that?

@ddollar ddollar closed this May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants