Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: allow ledger flag work with coin type 60 #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: allow ledger flag work with coin type 60 #690

wants to merge 8 commits into from

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 8, 2025 •
edited
Loading

Description

to avoid no hardware wallets detected error when generate address with Ethereum app with ledger

evmd keys add evm --ledger --output json --keyring-backend test --coin-type 60 --key-type eth_secp256k1
{"name":"evm","type":"ledger","address":"cosmos10729x95dvkpch5cjtkuuqzpjap4jml8h2nd3jp","pubkey":"{\"@type\":\"/cosmos.evm.crypto.v1.ethsecp256k1.PubKey\",\"key\":\"AkRZ92Z8La7a7ym785t5+yL3hHPY/ITyAqeR4R5CQIYd\"}"}

also allow generate address with Cosmos app

evmd keys add cosmos --ledger --output json --keyring-backend test --coin-type 118 --key-type secp256k1
{"name":"cosmos","type":"ledger","address":"cosmos16njlan774gn2jjghpgtuye9xhcmeyz9n66rncz","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"A8b4BN01/O0SA7nMMDVGnKbK3WebKNl+aTz09mKF91wy\"}"}

for more info

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

mmsqe added 2 commits October 8, 2025 18:46
@mmsqe
fix: allow ledger flag work with coin type 60
28607e6 
aligned ledger firmware with go-ethereum
@mmsqe
lint
cc0f62b
@aljo242
Copy link
Contributor

aljo242 commented Oct 8, 2025

Is there a way we can test this in the code?

@mmsqe
Copy link
Contributor Author

mmsqe commented Oct 8, 2025

Is there a way we can test this in the code?

You mean simulator like https://github.com/Zondax/zemu?

@aljo242
Copy link
Contributor

aljo242 commented Oct 8, 2025

yes

@mmsqe mmsqe mentioned this pull request Oct 10, 2025
Merged
@mmsqe mmsqe marked this pull request as draft October 10, 2025 00:34
@mmsqe
Copy link
Contributor Author

mmsqe commented Oct 16, 2025

yes

I tried several models in https://github.com/MANTRA-Chain/mantrachain-e2e/pull/93/files, maybe an unit test is enough in here?

@mmsqe mmsqe marked this pull request as ready for review October 23, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmsqe @aljo242