(chore): move feemarket update BaseFee to EndBlock #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
approved these changes
May 30, 2025
|
Hi @Eric-Warehime and @vladjdk , I believe this PR is missing needed adjustment corresponding to the old BeginBlock logic. Like this: Line 478 in f9b89bc |
Contributor
@0xbcdev Can you expand on the issue you see here? It seems like the |
1 task
mmsqe
added a commit
to mmsqe/evm
that referenced
this pull request
Jul 1, 2025
This reverts commit b2b7947.
9 tasks
vladjdk
pushed a commit
that referenced
this pull request
Jul 5, 2025
mmsqe
added a commit
to mmsqe/evm
that referenced
this pull request
Aug 2, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* move feemarket update to endblock * adjust comments
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the feemarket base fee updates to the end of the block for easier gas fee estimation.
Closes: #123