Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: align eth_feeHistory with geth #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 14, 2025
Merged

fix: align eth_feeHistory with geth #246

merged 6 commits into from
Jul 14, 2025

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jun 25, 2025 •
edited
Loading

Description

  1. To align fee_history in test_basic
  • fixes broken earliest/latest block tag handling
  • aligns blockCount as hexOrDecimal64 for EIP-1559 compatibility that breaks contract deploy in Foundry
  • ensures proper baseFeePerGas array length calculations
  • corrects oldestBlock return value (-1 discrepancy) with go-ethereum
  1. correct handling of next block fee for historical block should not change based on latest block in test_change
  2. rejects requests beyond current head block in test_beyond_head
  3. error handling for invalid reward percentile in test_percentiles
  4. ensures consistent results across concurrent block fetches in test_concurrent
  5. ensures update parameter changes not breaking historical data consistency in test_param_change

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@mmsqe
fix: align eth_feeHistory with geth
a6e4e05 
resolve EarliestBlockNumber from 0 to -5

for more info, ethereum/go-ethereum@bc36f2d
@mmsqe mmsqe marked this pull request as ready for review June 26, 2025 01:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2025
View reviewed changes
vladjdk
vladjdk requested changes Jul 4, 2025
View reviewed changes
Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution! One small fix on my end - using block 0 will yield the latest block, and not the earliest block, as it's coded right now. Let's fix the code for that and add a test case for the correct behaviour. Rest lgtm!

rpc/backend/chain_info.go

switch lastBlock {
case rpc.EarliestBlockNumber:
blockEnd = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earliest should be 1 here. If we use 0, then line 242's call to TendermintBlockByNumber will return the latest block:

evm/rpc/backend/blocks.go

Lines 164 to 168 in e6fe094

if height <= 0 {
// fetch the latest block number from the app state, more accurate than the tendermint block store state.
n, err := b.BlockNumber()
if err != nil {
return nil, err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Height in TendermintBlockByNumber returns 1 on 0 to handle earliest block case

tests/integration/rpc/backend/test_chain_info.go
},
},
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a testcase for earliest block time (0).

@vladjdk vladjdk requested a review from aljo242 July 4, 2025 15:35
@Pitasi Pitasi mentioned this pull request Jul 7, 2025
Closed
@mmsqe mmsqe requested a review from vladjdk July 9, 2025 10:43
@vladjdk vladjdk merged commit cb64292 into cosmos:main Jul 14, 2025
15 checks passed
mmsqe added a commit to mmsqe/evm that referenced this pull request Aug 2, 2025
@mmsqe
fix: align eth_feeHistory with geth (cosmos#246)
c7c52e0 
* fix: align eth_feeHistory with geth

resolve EarliestBlockNumber from 0 to -5

for more info, ethereum/go-ethereum@bc36f2d

* cleanup

* Apply suggestions from code review

---------

Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladjdk vladjdk vladjdk approved these changes

@aljo242 aljo242 aljo242 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmsqe @vladjdk @aljo242