fix(grpc): add sanity check to trace_tx #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
approved these changes
Jul 17, 2025
Member
|
@thomas-nguy lints failing |
Contributor
|
@thomas-nguy looks like we need a lint fix |
jeremyletang
added a commit
to mezo-org/mezod
that referenced
this pull request
Jul 22, 2025
Signed-off-by: Jeremy Letang <[email protected]>
lukasz-zimnoch
added a commit
to mezo-org/mezod
that referenced
this pull request
Jul 22, 2025
close: https://linear.app/thesis-co/issue/TET-1386/patch-a-tracetx-dos-vector-in-the-grpc-api ### Introduction Backport fixes from cosmos/evm regarding a panic which could happen when calling traceTx directly from the grpc API. ### Changes Add validation fo the req.Msg field in appropriate places ### Testing N/A ### Author's checklist - [x] Provided the appropriate description of the pull request - [x] Updated relevant unit and integration tests - [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [x] Assigned myself in the `Assignees` field - [x] Assigned `mezod-developers` in the `Reviewers` field and notified them on Discord ### Reviewer's checklist - [ ] Confirmed all author's checklist items have been addressed - [ ] Considered security implications of the code changes - [ ] Considered performance implications of the code changes - [ ] Tested the changes and summarized covered scenarios and results in a comment
lukasz-zimnoch
pushed a commit
to mezo-org/mezod
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Jeremy Letang <[email protected]>
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* fix tracetx * update changelog * fix lint * fix unit tests * fix unit tests --------- Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: The node panic for an empty request
e.g
Solution: Add more sanity check
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md