Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zsystm
Copy link
Collaborator

@zsystm zsystm commented Jul 21, 2025

Description

EmitApprovalEvent should emit the owner's address instead of the precompile address.

Otherwise, when transferFrom is called, the emitted event incorrectly shows the precompile address as the approver instead of the actual owner.

This change is verified in a separate end-to-end test (added in a #253), since it's more appropriate to test this behavior at the integration level. You can confirm the expected behavior in the following commit: 43d0962

Closes: #318


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@zsystm zsystm changed the title fix: EmitApprovalEvent should use owner address fix: use owner address instead of precompile in EmitApprovalEvent Jul 21, 2025
@zsystm zsystm marked this pull request as ready for review July 21, 2025 14:30
@zsystm zsystm requested review from a team as code owners July 21, 2025 14:30
@aljo242
Copy link
Contributor

aljo242 commented Jul 21, 2025

@zsystm can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context.

@zsystm
Copy link
Collaborator Author

zsystm commented Jul 21, 2025

@zsystm can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context.

Created #318 and linked the issue in PR description.

@aljo242 aljo242 enabled auto-merge July 21, 2025 17:44
@aljo242 aljo242 added this pull request to the merge queue Jul 21, 2025
Merged via the queue into cosmos:main with commit 17c65a7 Jul 21, 2025
16 checks passed
zsystm added a commit to zsystm/evm that referenced this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EmitApprovalEvent emits incorrect approver address

2 participants