fix: add break label in ws loop to properly escape outer loop #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there a way to test this functionality? |
Contributor
Author
|
@aljo242 We'd have to devise a test suite for the private methods. It might be more trouble than it's worth as this is just a fix meant to reflect the intent of the original logic and not a behavioral change. |
Contributor
|
@aljo242 to review today |
aljo242
approved these changes
Jul 28, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #348
The WebSocket logic conditionally uses
return,continue, andbreakas part of its control flow. However, thebreakstatements inside theswitchblock is a no-op as it just exits the switch (which will happen anyways as it's the last statement in the case).If the original intent is to exit the read loop and stop the socket flow entirely, we need a label for the outer loop and
breakthat instead.Author Checklist
I have...
mainbranchReviewers Checklist
I have...
Unreleasedsection inCHANGELOG.md