Remove --only-diff flag #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was not working fine, after all. Also, the only difference between `copier copy` and `copier update` is that copying should ignore subproject history, while updating should respect it. Thus, the real CLI reflection of the `only_diff` option is whether you're using `copier copy` or `copier update`. Well, that's how it is now. Besides all this, the real behavior of `only_diff=False` wasn't being tested. Fixed also, and updated docs. Fixes #270.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was not working fine, after all.
Also, the only difference between
copier copyandcopier updateis that copying should ignore subproject history, while updating should respect it.Thus, the real CLI reflection of the
only_diffoption is whether you're usingcopier copyorcopier update. Well, that's how it is now.Besides all this, the real behavior of
only_diff=Falsewasn't being tested. Fixed also, and updated docs.Fixes #270.