Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix temporary directory removal on Windows #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 4, 2021
Merged

Fix temporary directory removal on Windows #358

merged 9 commits into from
Mar 4, 2021

Conversation

@pawamoy
Copy link
Contributor

@pawamoy pawamoy commented Feb 14, 2021

Issue #345

Draft to see how CI behaves.

@pawamoy pawamoy marked this pull request as draft February 14, 2021 11:41
@yajo
Copy link
Member

yajo commented Feb 15, 2021

This may be unrelated, but you might be interested in this patch I had to add in the refactor:

copier/copier/main.py

Lines 285 to 289 in b3190c2

except (IsADirectoryError, PermissionError) as error:
# HACK https://bugs.python.org/issue43095
if isinstance(error, PermissionError):
if not (error.errno == 13 and platform.system() == "Windows"):
raise

See https://bugs.python.org/issue43095 for more details.

@pawamoy
Copy link
Contributor Author

pawamoy commented Feb 23, 2021

I don't think the failure on MacOS and Python 3.7 is related to my changes here. I'll add tests anyway, of course.

@yajo
Copy link
Member

yajo commented Feb 23, 2021

Ah... rebase please, that's fixed on master.

@pawamoy
Copy link
Contributor Author

pawamoy commented Feb 24, 2021

The Poetry issue comes from its new core version. The solution is to make it less verbose: poetry install -v instead of -vvv.

@pawamoy
Copy link
Contributor Author

pawamoy commented Feb 28, 2021

I'll wait for you to merge #364 and I'll rebase.

@codecov-io
Copy link

codecov-io commented Mar 1, 2021 •
edited
Loading

Codecov Report

Merging #358 (199d487) into master (0eddab7) will decrease coverage by 0.08%.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   97.04%   96.95%   -0.09%     
==========================================
  Files          35       35              
  Lines        2132     2170      +38     
==========================================
+ Hits         2069     2104      +35     
- Misses         63       66       +3
Flag Coverage Ξ”
unittests 96.95% <93.18%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
copier/tools.py 93.47% <87.50%> (-2.24%) ⬇️
copier/main.py 95.04% <100.00%> (-0.02%) ⬇️
copier/types.py 90.56% <100.00%> (+0.36%) ⬆️
copier/vcs.py 100.00% <100.00%> (ΓΈ)
tests/test_tools.py 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 0eddab7...199d487. Read the comment docs.

@pawamoy
Copy link
Contributor Author

pawamoy commented Mar 1, 2021 •
edited
Loading

Alright!

I've decomposed the process:

  • 9c86e1c adds tests for this particular issue, they pass on Windows for Python 3.8 and 3.9.
  • 8391596 re-enables Windows for Python 3.6 and 3.7, tests are failing as expected
  • ce00fd7 fixes the issue by implementing a more robust deletion mechanism in a custom temporary directory class, tests are passing again on Windows for all tested Python versions

Please squash as I pushed commits disabling/enabling things in CI that were only used to speed things up.

@pawamoy pawamoy marked this pull request as ready for review March 1, 2021 14:15
@pawamoy
Copy link
Contributor Author

pawamoy commented Mar 1, 2021

Pexpect timeout again on MacOs + Python 3.6 πŸ˜•

yajo
yajo requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawamoy
Copy link
Contributor Author

pawamoy commented Mar 1, 2021

How many random CI failures will I meet πŸ˜‚

@pawamoy
Copy link
Contributor Author

pawamoy commented Mar 3, 2021 •
edited
Loading

Could you re-run the jobs to see if the codecov error goes away? Unless you already did?
UPDATE: triggered again by resolving conflict on poetry.lock. Seems better!
TWO SECONDS LATER: noooo the last job failed with pexpect timeouts again 😭

@yajo
Copy link
Member

yajo commented Mar 4, 2021

Oh man what's up with that mac? πŸ€¦πŸΌβ€β™‚οΈ

I could debug that if somebody buys me a mac. Otherwise I suggest you to mark that test as not forced xfail. πŸ€·πŸΌβ€β™‚οΈ

@yajo yajo enabled auto-merge (squash) March 4, 2021 16:00
@yajo yajo merged commit 76d6c2f into copier-org:master Mar 4, 2021
@yajo
Copy link
Member

yajo commented Mar 4, 2021

Finally! thanks 😊

@pawamoy pawamoy deleted the fix-rmtree-git-windows branch April 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yajo yajo yajo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawamoy @yajo @codecov-io