Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(operator): support SecRule "! ^some" as a valid @rx negation #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2022
Merged

feat(operator): support SecRule "! ^some" as a valid @rx negation #197

merged 2 commits into from
Mar 10, 2022

Conversation

@syinwu
Copy link
Member

@syinwu syinwu commented Mar 10, 2022

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.

Make sure that you've checked the boxes below before you submit PR:

Thanks for your PR ❤️

@syinwu syinwu requested review from fzipi and jptosso March 10, 2022 03:37
@syinwu syinwu linked an issue Mar 10, 2022 that may be closed by this pull request
Support SecRule "! ^some$" as a valid @rx negation #195
Closed
jptosso
jptosso requested changes Mar 10, 2022
View reviewed changes
@syinwu syinwu changed the title support for #195 feat(operator): support SecRule "! ^some" as a valid @re negation Mar 10, 2022
@syinwu syinwu added the enhancement New feature or request label Mar 10, 2022
@syinwu syinwu requested a review from jptosso March 10, 2022 06:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@syinwu syinwu changed the title feat(operator): support SecRule "! ^some" as a valid @re negation feat(operator): support SecRule "! ^some" as a valid @rx negation Mar 10, 2022
jptosso
jptosso approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@jptosso jptosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi
Copy link
Member

fzipi commented Mar 10, 2022

Well... this looks like compatibility :)

In CRS we changed to use explicit operators while back, and it makes sense. But I don't think being compatible hurts in this case.

@jptosso jptosso merged commit 62dd3db into v2/master Mar 10, 2022
@jptosso jptosso deleted the v2/#195 branch March 10, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jptosso jptosso jptosso approved these changes

@fzipi fzipi fzipi approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support SecRule "! ^some$" as a valid @rx negation

4 participants

@syinwu @fzipi @jptosso