Refine Modals #495
Closed
Refine Modals #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d10283 to
6d2a9c8
Compare
adc72b4 to
1bb0778
Compare
1bb0778 to
d04f628
Compare
d04f628 to
4b10cd5
Compare
|
Rebased and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal Drawer is now the default except for HUD, profiles and feed Edit
The side drawer has a max-width-md applied, opens from the left, the sidebar is still visible and accessible
When another drawer opens it fully covers the first one
When opening a profile page, we still have the former modal, but the side menu is still visible, I thought it was ok, but I can put it in the background if needed
On mobile the modal still open from the bottom, I can open it from the side if needed, it is now dismissible with a swap.
Screen.Recording.2024-11-28.at.17.49.58.mov