Fix `open with` for note kind #1 #497

ticruz38 · 2024-11-29T15:08:21Z

The rendering architecture needs to change, since we switch on kind only within NoteContent. With e.g. feeds, it will make more sense to swap out rendering for the entirety of the note instead. Kind handlers should only show up on non-kind-1 notes, and probably be integrated more tightly with the content. Also use a different icon.

I don't have the context or state of Coracle at the time of this comment but from what I can see in the code, I have some questions:

You do still switch NoteContent based on kind.
By entirety of the note do you mean having NoteActions embedded in NoteContent? I like both being separated still.
Kind Handlers are tightly integrated with the note content, as it seems each handlers has a kind "attached" to it. You are already switching handlers based on the Note kind. Or you want to use another means, aside from the note kind, to filter out the Note handler?
The icon choice is quite limited on Font-Awesome, I came up with the fa-list icon, which seems more appropriate, for a wider range of icon I personally use iconify, but that's a big departure from font-awesome, even though iconify support font-awesome too. It does add some dependencies that you need to be confortable with.

ticruz38 · 2024-12-02T13:06:01Z

https://github.com/ticruz38/coracle/tree/fix/open-with-iconify

Check this branch out for an iconify version

staab · 2024-12-02T17:50:54Z

The iconify version looks better, but we shouldn't add a dependency. See if you can get something like that into Icon.svelte in svg format (although with an arrow would be preferable). I often use https://www.flaticon.com/ for stuff like this.

For an illustration of what I mean, certain note kinds should ideally be able to take over the layout of the profile picture etc. to differentiate them from normal notes. Here's how a feed event currently looks:

Which obviously is not ideal. Here's an example of how it might look:

This is going to be very hairy to accomplish, since it'll require allowing NoteContentX components to call NoteActions internally, or maybe use crazy slots. Then, of course, there are quotes, which are already convoluted to avoid circular dependencies. The simplest solution might be to add logic to Note.svelte, but that's going to be ugly too. I'd really like the solution to be very clean, since there is so much mission-critical stuff going on in these files.

ticruz38 · 2024-12-05T17:02:49Z

I'm halfway there. Here's what I have done so far:

Removed a lot of logic from Note.svelte, renaming it to Thread.svelte. It now defines the layout for each thread in the feed. A thread consists of a note and its replies and/or parents.
NoteContent.svelte is now NoteKind.svelte (to be renamed Note.svelte). NoteKind aggregates a NoteHeader, NoteContent, and NoteActions (footer) together. This allows us to remove the NoteHeader for certain NoteKind types, such as the Feed Event in your example.
NoteActions now takes on the bulk of the logic, such as counting/executing zaps, likes, replies, etc. This removes a ton of code from Note.svelte (now Thread.svelte) that was previously passed via props to the NoteActions component.

What's left to do:

The NoteReply component will use a store to set which note is being replied to or is still a draft, instead of relying on the replyCtrl binding.
Make sure I did not drop any CSS subtlety during the refactor

ticruz38 · 2024-12-05T17:09:10Z

What could be nice trying:

Use svelte-infinite-scroll. This component allows us to determine what is visible on screen, which might give us an opportunity to optimise performance by only requesting/computing information for the elements on-screen or nearby. I'm thinking mostly of NoteActions.svelte, this one is probably the most expensive.

staab

Interesting, looks fine so far, but I'm curious to see what it would look like applied to specific note kinds (e.g. feeds)

src/app/shared/Feed.svelte

staab · 2024-12-05T18:55:59Z

I've gone ahead and bumped this update to 0.6.0 since it's more substantial than I was expecting.

ticruz38 · 2024-12-12T13:24:41Z

This PR primarily refactor the Note.svelte component now renamed FeedItem.svelte

Note.svelte now represent just a single note in the feed and is divided into 3 parts: header, content and actions (footer).
It is now easier to fine tune the display depending on the note kind.

The "Open With" action now uses Niels' icon.

staab · 2024-12-13T19:51:15Z

Looks pretty good, can you fix conflicts? Also, can we get the icon to be a little thicker? The lines are skinnier than font-awesome's, so it looks sort of disabled.

ticruz38 · 2024-12-16T14:19:20Z

rebased dev and increase open-with stroke width

staab · 2024-12-16T16:55:40Z

src/app/shared/NoteReply.svelte

+  const openOptions = () => {
+    showOptions = true
+  }
+
+  const setOpts = e => {
+    opts = {...opts, ...e.detail}


Looks like you've undone some of my changes, options are no longer working correctly on replies

staab · 2024-12-16T16:56:11Z

src/app/shared/NoteReply.svelte

-    {#if showBorder}
+    <!-- {#if showBorder}
      <AltColor background class="absolute -top-4 z-none h-5 w-1" />
-    {/if}
-    <div
-      transition:slide|local
-      class="note-reply relative my-2 gap-1"
-      bind:this={container}
-      on:click|stopPropagation>
+    {/if} -->
+    <div transition:slide|local class="note-reply relative my-2 gap-1" on:click|stopPropagation>


This looks unresolved

staab

Just a couple small things, when resolving conflicts try to keep the changes made upstream rather than revert them

src/app/shared/NoteActions.svelte

src/app/shared/NoteReply.svelte

- Refactor reply state

- add openWith icon

* hide `open with` for kind 1 and change the icon * refactor note thread * - Rename Thread to FeedItem - Refactor reply state * - fix NoteActions when logged out - add openWith icon * rename NoteKind to Note * fine tune the padding for feed note * increase open-with icon stroke-width * fix rebase * merge fix

staab changed the base branch from master to dev December 2, 2024 17:29

ticruz38 force-pushed the fix/open-with branch from 872e27a to b0be399 Compare December 5, 2024 16:48

staab mentioned this pull request Dec 5, 2024

Optimize based on what is onscreen #501

Open

staab modified the milestone: 0.6.0 Dec 5, 2024

staab reviewed Dec 5, 2024

View reviewed changes

src/app/shared/Feed.svelte Outdated Show resolved Hide resolved

ticruz38 force-pushed the fix/open-with branch 4 times, most recently from 1bd9f3a to 84ae5c2 Compare December 12, 2024 13:19

ticruz38 requested a review from staab December 13, 2024 13:32

ticruz38 force-pushed the fix/open-with branch from 84ae5c2 to 222b87c Compare December 16, 2024 14:05

staab reviewed Dec 16, 2024

View reviewed changes

ticruz38 force-pushed the fix/open-with branch from bfca26c to 0830452 Compare December 17, 2024 13:41

staab reviewed Dec 17, 2024

View reviewed changes

src/app/shared/NoteActions.svelte Show resolved Hide resolved

src/app/shared/NoteReply.svelte Outdated Show resolved Hide resolved

src/app/shared/NoteReply.svelte Outdated Show resolved Hide resolved

staab force-pushed the dev branch from bf50f94 to 042d6c7 Compare December 17, 2024 18:14

ticruz38 added 6 commits December 18, 2024 14:14

hide open with for kind 1 and change the icon

d6f19de

refactor note thread

c5fb090

- Rename Thread to FeedItem

9ce0223

- Refactor reply state

- fix NoteActions when logged out

26e8db1

- add openWith icon

rename NoteKind to Note

289bae0

fine tune the padding for feed note

3de0aba

ticruz38 added 3 commits December 18, 2024 14:14

increase open-with icon stroke-width

dd0c430

fix rebase

7b89340

merge fix

692e82b

ticruz38 force-pushed the fix/open-with branch from 0830452 to 692e82b Compare December 18, 2024 13:14

staab merged commit 417e1b5 into coracle-social:dev Dec 18, 2024
2 checks passed

Uh oh!

Fix open with for note kind #1 #497

Fix open with for note kind #1 #497

Uh oh!

Conversation

ticruz38 commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ticruz38 commented Dec 2, 2024

Uh oh!

staab commented Dec 2, 2024

Uh oh!

ticruz38 commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ticruz38 commented Dec 5, 2024

Uh oh!

staab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

staab commented Dec 5, 2024

Uh oh!

ticruz38 commented Dec 12, 2024

Uh oh!

staab commented Dec 13, 2024

Uh oh!

ticruz38 commented Dec 16, 2024

Uh oh!

staab Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

staab Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

staab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix `open with` for note kind #1 #497

Fix `open with` for note kind #1 #497

ticruz38 commented Nov 29, 2024 •

edited

Loading

ticruz38 commented Dec 5, 2024 •

edited

Loading